netdev - Re: [net-next-2.6 PATCH] e1000/e1000e/igb/ixgb: don't txhang after link down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090507.145637.154290988.davem@davemloft.net>
Date:	Thu, 07 May 2009 14:56:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	jesse.brandeburg@...el.com
Subject: Re: [net-next-2.6 PATCH] e1000/e1000e/igb/ixgb: don't txhang after
 link down

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Thu, 07 May 2009 14:07:35 -0700

> after the recent changes to wired drivers to use only
> netif_carrier_off the driver can have outstanding tx work to
> complete that will never complete once link is down.  Since the
> intel hardware will hold this tx work forever, the driver
> notices a tx timeout condition internally and might try
> to instigate printk and reset of the part with a
> netif_stop_queue, which doesn't work because link is down.
> 
> Don't bother arming to tx hang detection when link is down.
> 
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html