netdev - Re: [PATCH] net/fs_enet/mii-fec: Use PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa686aa40905080855g1b24b9f4s7a78ccb75b5be8b1@mail.gmail.com>
Date:	Fri, 8 May 2009 09:55:31 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Wolfram Sang <w.sang@...gutronix.de>
Cc:	Vitaly Bordug <vbordug@...mvista.com>,
	Pantelis Antoniou <pantelis.antoniou@...il.com>,
	netdev@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: [PATCH] net/fs_enet/mii-fec: Use PHY_POLL instead of hard coded 
	'-1'

On Fri, May 8, 2009 at 8:00 AM, Wolfram Sang <w.sang@...gutronix.de> wrote:
> Initialize the irq-table with PHY_POLL. '-1' means the same now, but is
> hardly maintainable.
>
> Signed-off-by: Wolfram Sang <w.sang@...gutronix.de>
> Cc: Vitaly Bordug <vbordug@...mvista.com>
> Cc: Pantelis Antoniou <pantelis.antoniou@...il.com>
> Cc: Grant Likely <grant.likely@...retlab.ca>
> Cc: netdev@...r.kernel.org
> Cc: linuxppc-dev@...abs.org
> ---
>  drivers/net/fs_enet/mii-fec.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/fs_enet/mii-fec.c b/drivers/net/fs_enet/mii-fec.c
> index 28077cc..9eb5480 100644
> --- a/drivers/net/fs_enet/mii-fec.c
> +++ b/drivers/net/fs_enet/mii-fec.c
> @@ -166,7 +166,7 @@ static int __devinit fs_enet_mdio_probe(struct of_device *ofdev,
>                goto out_unmap_regs;
>
>        for (i = 0; i < PHY_MAX_ADDR; i++)
> -               new_bus->irq[i] = -1;
> +               new_bus->irq[i] = PHY_POLL;

This code no longer exists in net-next.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html