netdev - Re: [PATCH]ipv6:use ipv6_addr_type instead of __ipv6_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090508.004420.22402966.davem@davemloft.net>
Date:	Fri, 08 May 2009 00:44:20 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	yanghy@...fujitsu.com
Cc:	netdev@...r.kernel.org, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH]ipv6:use ipv6_addr_type instead of __ipv6_addr_type

From: Yang Hongyang <yanghy@...fujitsu.com>
Date: Fri, 08 May 2009 09:18:11 +0800

> David Miller wrote:
>> From: Yang Hongyang <yanghy@...fujitsu.com>
>> Date: Thu, 07 May 2009 15:47:38 +0800
>> 
>>> Although the function of these two functions are the same,we should use the
>>> encapsulation function of __ipv6_addr_type
>>>
>>> Signed-off-by: Yang Hongyang<yanghy@...fujitsu.com>
>> 
>> Are you sure?  ipv6_addr_type() masks out the upper 16-bits
>> of __ipv6_addr_type()'s return value, which is the scope.
>> 
>> I'm not convinced that is what we want to do here.
> 
> My advice here is that the function which has __ maybe shouldn't be directly used.

You're using vague terms like "advice" and "maybe" and this
only decreases my confidence in your change.

You're also not addressing my questions at all.

Two "_" characters at the beginning of the function's name says
nothing about whether these call sites want the scope bits present in
the return value they receive.

This seems like a completely pointless and mindless change,
and in fact might introduce bugs.

There is no way I'm applying this.  You can't even explain if the
patch is correct or not.  In fact, I doubt you even know.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html