lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 9 May 2009 20:14:34 +0200 From: Frans Pop <elendil@...net.nl> To: "Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi> Cc: Matthias Andree <matthias.andree@....de>, David Miller <davem@...emloft.net>, Netdev <netdev@...r.kernel.org> Subject: Re: Strange Application bug, race in MSG_PEEK complaints (was: Bug#513695: fetchmail: race in MSG_PEEK) On Thursday 07 May 2009, Ilpo Järvinen wrote: > [RFC PATCH] tcp: fix MSG_PEEK race check > > Commit 518a09ef11 (tcp: Fix recvmsg MSG_PEEK influence of > blocking behavior) lets the loop run longer than this check > did previously expect, so we need to be more careful with > this check and consider the work we have been doing. > > I'm a bit unsure if this improved check can still fail as > if (!sock_flag(sk, SOCK_URGINLINE)) { > ++*seq; > ... > does not increment copied. > > Compile tested. > > Signed-off-by: Ilpo J?rvinen <ilpo.jarvinen@...sinki.fi> I've been running with the patch for 2 days now and have not seen any more MSG_PEEK errors, so as far as I'm concerned the patch does fix the issue (needed the time in order to be confident of that). So: Tested-by: Frans Pop <elendil@...net.nl> Suggest to also add a CC for stable. Cheers, FJP -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists