netdev - Re: [PATCH] bonding: fix panic if initialization fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090509.132000.242388766.davem@davemloft.net>
Date:	Sat, 09 May 2009 13:20:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jpirko@...hat.com
Cc:	fw@...len.de, bonding-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH] bonding: fix panic if initialization fails

From: Jiri Pirko <jpirko@...hat.com>
Date: Sat, 9 May 2009 01:36:04 +0200

> Sat, May 09, 2009 at 01:30:57AM CEST, fw@...len.de wrote:
>>Jiri Pirko <jpirko@...hat.com> wrote:
>>> > err:
>>> >-	list_for_each_entry(bond, &bond_dev_list, bond_list) {
>>> >-		bond_work_cancel_all(bond);
>>> >-		destroy_workqueue(bond->wq);
>>> >-	}
>>> This looks correct.
>>> 
>>> >-
>>> >-	bond_destroy_sysfs();
>>> Why this is not here anymore? I think it should be called in this function.
>>
>>Thanks for reviewing.
>>I removed it because, if you hit this error path, sysfs registration
>>failed, so there is no entry to remove.
> 
> Yes, you are right.
> 
> Signed-off-by: Jiri Pirko <jpirko@...hat.com>

Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html