netdev - Re: tun: add tun_flags, owner, group attributes in sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1241908073.24436.27.camel@macbook.infradead.org>
Date:	Sat, 09 May 2009 23:27:53 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, markmc@...hat.com
Subject: Re: tun: add tun_flags, owner, group attributes in sysfs

On Sat, 2009-05-09 at 13:27 -0700, David Miller wrote:
> From: David Woodhouse <dwmw2@...radead.org>
> Date: Mon, 04 May 2009 11:32:16 +0100
> 
> > I don't have to explicitly remove the files, do I? They go away
> > naturally when the device is unregistered?
> 
> I'm not so sure about this.  I can't see anything in the
> drivers/base/core.c code that automatically deletes anything
> other than device groups and attributes.

Hm, I really do think the attributes go away automatically when the
parent device does.

If not, gianfar_sysfs.c and niu.c want fixing too -- and we should
probably have a WARN_ON() in the sysfs code when it happens, if
possible.

I'll experiment (since I'm getting lost when I try to work it out by
inspection).

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html