netdev - Re: [PATCH] ipconfig: handle case of delayed DHCP server

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090510.010821.00122250.davem@davemloft.net>
Date:	Sun, 10 May 2009 01:08:21 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ebiederm@...ssion.com
Cc:	cfriesen@...tel.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH] ipconfig: handle case of delayed DHCP server

From: ebiederm@...ssion.com (Eric W. Biederman)
Date: Sun, 10 May 2009 00:53:03 -0700

> David Miller <davem@...emloft.net> writes:
> 
>> From: "Chris Friesen" <cfriesen@...tel.com>
>> Date: Fri, 08 May 2009 14:56:11 -0600
>>
>>> 
>>> +	/* Is it a reply for the device we are configuring? */
>>> +	if (b->xid != ic_dev_xid) {
>>> +		if (net_ratelimit())
>>> + printk(KERN_ERR "DHCP/BOOTP: Ignoring delayed packet \n");
>>> +		goto drop_unlock;
>>
>> Please don't use such odd indentation for this printk
>> statement.
> 
> Weird it looked ok in my mailer 3 tabs in, and out to coloumn 82.  Dave someting
> word wrap it for you?

I hope it's not my arch-nemesis, format=flowed :-/
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html