netdev - [PATCH 1/1] NIU: fix spurious interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1242068453-5124-2-git-send-email-hong.pham@windriver.com>
Date:	Mon, 11 May 2009 15:00:53 -0400
From:	"Hong H. Pham" <hong.pham@...driver.com>
To:	netdev@...r.kernel.org
Cc:	"Hong H. Pham" <hong.pham@...driver.com>
Subject: [PATCH 1/1] NIU: fix spurious interrupts

It's possible for an interrupt to be triggered while NAPI is in progress
(at least on a SPARC64 SUN4V system).  Unconditionally call
__niu_fastpath_interrupt() in niu_schedule_napi() to mask out the logical
device being serviced to avoid further spurious interrupts from being
generated.

Signed-off-by: Hong H. Pham <hong.pham@...driver.com>
---
 drivers/net/niu.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/niu.c b/drivers/net/niu.c
index 2b17453..80d4fb6 100644
--- a/drivers/net/niu.c
+++ b/drivers/net/niu.c
@@ -4221,11 +4221,11 @@ static void niu_schedule_napi(struct niu *np, struct niu_ldg *lp,
 	if (likely(napi_schedule_prep(&lp->napi))) {
 		lp->v0 = v0;
 		lp->v1 = v1;
 		lp->v2 = v2;
-		__niu_fastpath_interrupt(np, lp->ldg_num, v0);
 		__napi_schedule(&lp->napi);
 	}
+	__niu_fastpath_interrupt(np, lp->ldg_num, v0);
 }

 static irqreturn_t niu_interrupt(int irq, void *dev_id)
 {
-- 
1.6.0.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html