netdev - Re: [IPSEC] xfrm_state locking problem in xfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 May 2009 09:32:04 -0400
From:	Yury Polyanskiy <ypolyans@...nceton.EDU>
To:	David Miller <davem@...emloft.net>
Cc:	herbert@...dor.apana.org.au, netdev@...r.kernel.org
Subject: Re: [IPSEC] xfrm_state locking problem in xfrm_input.c

On Mon, 11 May 2009 22:07:23 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> >> > Note that if the locally generated packet is sent to a local ip,
> >> > dev_queue_xmit() calls loopback_xmit() and the xfrm_input() will
> >> > be called with softirqs enabled.
> >> 
> >> dev_queue_xmit always disables BH before calling the device xmit
> >> function.  So how can this happen?
> >> 
> > 
> > Oops, you right. Thanks for the explanation!
> 
> So you didn't actually hit a bug that led you to write that
> patch?
> 
> Please state this explicitly next time, and tell us that you are
> "fixing" something based purely upon code inspection rather than
> hitting a bug yourself.
> 

Well, I hit some bug (occasional hard lockup of the box on ipsec'ed
data transfers), and this seemed as an excellent fit, because I
frequently test it on local->local trafic. Anyways, sorry for bothering.

YP

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)