netdev - Re: [PATCH] net: release dst entry in dev_hard_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090512200515.GB2757@ami.dom.local>
Date:	Tue, 12 May 2009 22:05:15 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Eric Dumazet <dada1@...mosbay.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH] net: release dst entry in dev_hard_start_xmit()

On Tue, May 12, 2009 at 09:44:52PM +0200, Eric Dumazet wrote:
> Jarek Poplawski a écrit :
> > On Tue, May 12, 2009 at 10:21:12AM +0200, Eric Dumazet wrote:
> >> Eric Dumazet a écrit :
> > ...
> >>> List of devices that must clear this flag is :
> >>>
> >>> - loopback device, because it calls netif_rx() and quoting Patrick :
> >>>     "ip_route_input() doesn't accept loopback addresses, so loopback packets
> >>>      already need to have a dst_entry attached."
> >>> - appletalk/ipddp.c : needs skb->dst in its xmit function
> >>>
> >>> - And all devices that call again dev_queue_xmit() from their xmit function
> >>> (as some classifiers need skb->dst) : bonding, macvlan, eql, ifb, hdlc_fr
> > 
> > Why not vlan (and/or maybe others in net/ using dev_queue_xmit)?
> > 
> 
> Yes I spoted vlan earlier this afternoon.
> 
> For other net/*, I didnt not find candidates yet.

Hmm..., if vlan, then why not pppoe (and/or maybe others in drivers/net/
using dev_queue_xmit)?

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html