netdev - Re: [PATCH 3/6] powerpc: add memory map support to Freescale RapidIO block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090512150552.a98dca64.akpm@linux-foundation.org>
Date:	Tue, 12 May 2009 15:05:52 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Li Yang <leoli@...escale.com>
Cc:	galak@...nel.crashing.org, davem@...emloft.net,
	mporter@...nel.crashing.org, linux-kernel@...r.kernel.org,
	linuxppc-dev@...abs.org, netdev@...r.kernel.org,
	leoli@...escale.com, zw@...kernel.org
Subject: Re: [PATCH 3/6] powerpc: add memory map support to Freescale
 RapidIO block

On Tue, 12 May 2009 16:36:00 +0800
Li Yang <leoli@...escale.com> wrote:

> +	align = (size < 0x1000) ? 0x1000 : 1 << (__ilog2(size - 1) + 1);
> +
> +	/* Align the size */
> +	if ((lstart + size) > (_ALIGN_DOWN(lstart, align) + align)) {

__ilog2() and _ALIGN_DOWN() are powerpc-specific functions.  It would
be preferable to use more general helpers if possible.  ALIGN() and ilog2()
might suit here.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html