netdev - Re: [patch 2/2] drivers/net/82596.c: suppress warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090513222909.GA4118@electric-eye.fr.zoreil.com>
Date:	Thu, 14 May 2009 00:29:09 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	akpm@...ux-foundation.org
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [patch 2/2] drivers/net/82596.c: suppress warnings

akpm@...ux-foundation.org <akpm@...ux-foundation.org> :
> i386 allmodconfig:
> 
> drivers/net/82596.c: In function 'init_rx_bufs':
> drivers/net/82596.c:544: warning: cast to pointer from integer of different size
> drivers/net/82596.c:545: warning: cast to pointer from integer of different size
[...]
> drivers/net/82596.c: In function 'i596_interrupt':
> drivers/net/82596.c:1404: warning: cast to pointer from integer of different size
> 
> (ugh)

I may sound like Pavlov's best friend but the use of virt_to_bus and
the 90's look of this (old) driver make me wonder if the use of so
many pointers is right in the first place. Ought some of those be
turned into plain u32 instead ?

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html