netdev - Re: [PATCH 0/2] igb: drop stats due to OS cannot keep up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9929d2390905141543g6f5adc32ndf65870bd49d83ea@mail.gmail.com>
Date:	Thu, 14 May 2009 15:43:15 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jesper Dangaard Brouer <hawk@...x.dk>
Cc:	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	"Ronciak, John" <john.ronciak@...el.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>
Subject: Re: [PATCH 0/2] igb: drop stats due to OS cannot keep up

On Thu, May 7, 2009 at 6:35 AM, Jesper Dangaard Brouer <hawk@...x.dk> wrote:
>
> The following patchset address "drop" stats counters in the igb
> driver (chips 82576 and 82575).  The drop stats addressed here
> are due to the OS cannot keep up.
>
> I have only tested it for the 82576 chip, as my (12 port) 82575
> chip based NIC from Hotlava Systems recently died in my testlab :-(((
>
> [First patch]
> Implements reading of the per queue drop stats.
> These stats only gets incremented if the DROP_EN bit it set (in
> the SRRCTL register for that queue, or QDE reg is set).
>
> [Second patch]
> Address the case where the DROP_EN it NOT set.  In
> this case a global register records the equivalent drop type. And
> aggregation of these two types of drops into the device net_stats.
>
> I strongly believe that these drops counters should be made
> available to sysadm's through the normal device stats.  These
> stats are essential when diagnosing server performance issues, as
> these stats are due to the OS cannot keep up. I strongly believe
> that it should be stored in the net_stats rx_fifo_errors counter,
> to indicate performance issues.
>
> --
> Med venlig hilsen / Best regards
>  Jesper Brouer
>  ComX Networks A/S
>  Linux Network developer
>  Cand. Scient Datalog / MSc.
>  Author of http://adsl-optimizer.dk
>  LinkedIn: http://www.linkedin.com/in/brouer
>

Jesper - I have pulled in your patches, and made the necessary
modifications based on Mitch's comments.  Right now, they are in
testing and I should be pushing them to Dave in the next couple of
days.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html