netdev - Re: [PATCH 1/5] sit: Fail to create tunnel, if it already exists,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090515133007.GK25620@psychotron.englab.brq.redhat.com>
Date:	Fri, 15 May 2009 15:30:08 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	Sascha Hlusiak <contact@...chahlusiak.de>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/5] sit: Fail to create tunnel, if it already exists,

Fri, May 15, 2009 at 02:52:47PM CEST, contact@...chahlusiak.de wrote:
>When locating the tunnel, do not continue if it is found. Otherwise
>a different tunnel with similar configuration would be returned and
>parts could be overwritten.

You are missing Signed-off-by line in the whole patchset.

>---
> net/ipv6/sit.c |    7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
>index 664ab82..bd63a7e 100644
>--- a/net/ipv6/sit.c
>+++ b/net/ipv6/sit.c
>@@ -165,8 +165,13 @@ static struct ip_tunnel * ipip6_tunnel_locate(struct net *net,
> 	struct sit_net *sitn = net_generic(net, sit_net_id);
> 
> 	for (tp = __ipip6_bucket(sitn, parms); (t = *tp) != NULL; tp = &t->next) {
>-		if (local == t->parms.iph.saddr && remote == t->parms.iph.daddr)
>-			return t;
>+		if (local == t->parms.iph.saddr &&
>+		    remote == t->parms.iph.daddr) {
>+			if (create)
>+				return NULL;
>+			else
>+				return t;
>+		}
> 	}
> 	if (!create)
> 		goto failed;
>-- 
>1.6.3
>
>--
>To unsubscribe from this list: send the line "unsubscribe netdev" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html