netdev - RE: [PATCH] Neterion: *FIFO1_DMA_ERR set twice, should 2nd be *FIFO2_DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 17 May 2009 03:52:59 -0400
From:	"Ramkrishna Vepa" <Ramkrishna.Vepa@...erion.com>
To:	"Roel Kluin" <roel.kluin@...il.com>
Cc:	<netdev@...r.kernel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: RE: [PATCH] Neterion: *FIFO1_DMA_ERR set twice, should 2nd be *FIFO2_DMA_ERR?

> FIFO1_DMA_ERR is set twice, the second should be FIFO2_DMA_ERR.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> Correct? Please review.
> 
> diff --git a/drivers/net/vxge/vxge-traffic.c b/drivers/net/vxge/vxge-
> traffic.c
> index 7be0ae1..c2eeac4 100644
> --- a/drivers/net/vxge/vxge-traffic.c
> +++ b/drivers/net/vxge/vxge-traffic.c
> @@ -115,7 +115,7 @@ enum vxge_hw_status
vxge_hw_vpath_intr_enable(struct
> __vxge_hw_vpath_handle *vp)
>  		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_POISON|
>  		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_POISON|
>  		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR|
> -		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR), 0,
32),
> +		VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_DMA_ERR), 0,
32),
>  		&vp_reg->kdfcctl_errors_mask);
> 
>  	__vxge_hw_pio_mem_write32_upper(0,
&vp_reg->vpath_ppif_int_mask);
[Ram] Good catch!
Acked-by: Ram Vepa <ram.vepa@...erion.com>

Thanks,
Ram
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html