netdev - Re: [IGB 2.6.29.3 bug] Re: WARNING at dev_disable_lro when enabling ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9929d2390905181607v24a6c7a0t7d74e1388f131ef9@mail.gmail.com>
Date:	Mon, 18 May 2009 16:07:36 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	shemminger@...tta.com, sergk@...gk.org.ua, netdev@...r.kernel.org
Subject: Re: [IGB 2.6.29.3 bug] Re: WARNING at dev_disable_lro when enabling 
	ip_forward

On Mon, May 18, 2009 at 4:00 PM, David Miller <davem@...emloft.net> wrote:
> From: Stephen Hemminger <shemminger@...tta.com>
> Date: Mon, 18 May 2009 15:57:14 -0700
>
>> Does this fix it?
>
> It should, but I think the ifdef is probably superfluous.
>

I agree with Dave, the #ifdef is not necessary.  Thanks Stephen for
the quick patch.

>> diff --git a/drivers/net/igb/igb_ethtool.c b/drivers/net/igb/igb_ethtool.c
>> index 4bdfc2e..a425d85 100644
>> --- a/drivers/net/igb/igb_ethtool.c
>> +++ b/drivers/net/igb/igb_ethtool.c
>> @@ -2028,6 +2028,10 @@ static struct ethtool_ops igb_ethtool_ops = {
>>       .get_ethtool_stats      = igb_get_ethtool_stats,
>>       .get_coalesce           = igb_get_coalesce,
>>       .set_coalesce           = igb_set_coalesce,
>> +#ifdef CONFIG_IGB_LRO
>> +     .get_flags              = ethtool_op_get_flags,
>> +     .set_flags              = ethtool_op_set_flags,
>> +#endif
>>  };
>>
>>  void igb_set_ethtool_ops(struct net_device *netdev)

If this resolves Sergey's issue, I will push this to the stable tree
(minus the #ifdef).

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html