netdev - Re: [IGB 2.6.29.3 bug] Re: WARNING at dev_disable_lro when enabling ip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090518.164137.261504026.davem@davemloft.net>
Date:	Mon, 18 May 2009 16:41:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	shemminger@...tta.com
Cc:	sergk@...gk.org.ua, netdev@...r.kernel.org,
	jeffrey.t.kirsher@...el.com
Subject: Re: [IGB 2.6.29.3 bug] Re: WARNING at dev_disable_lro when
 enabling ip_forward

From: Stephen Hemminger <shemminger@...tta.com>
Date: Mon, 18 May 2009 16:08:04 -0700

> On Mon, 18 May 2009 16:00:29 -0700 (PDT)
> David Miller <davem@...emloft.net> wrote:
> 
>> > @@ -2028,6 +2028,10 @@ static struct ethtool_ops igb_ethtool_ops = {
>> >  	.get_ethtool_stats      = igb_get_ethtool_stats,
>> >  	.get_coalesce           = igb_get_coalesce,
>> >  	.set_coalesce           = igb_set_coalesce,
>> > +#ifdef CONFIG_IGB_LRO
>> > +	.get_flags		= ethtool_op_get_flags,
>> > +	.set_flags		= ethtool_op_set_flags,
>> > +#endif
>> >  };
>> >  
>> >  void igb_set_ethtool_ops(struct net_device *netdev)
> 
> For get, the ifdef is superflous, but for set you don't want
> the user to turn LRO on if not configured.

Stephen's right, ->set_flags has to be ifdef protected.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html