netdev - Re: [PATCH] bonding: fix link down handling in 802.3ad mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 17 May 2009 21:16:05 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fubar@...ibm.com
Cc:	shemminger@...tta.com, bonding-devel@...ts.sf.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH] bonding: fix link down handling in 802.3ad mode

From: Jay Vosburgh <fubar@...ibm.com>
Date: Fri, 15 May 2009 12:35:55 -0700

> Stephen Hemminger <shemminger@...tta.com> wrote:
> 
>>One of the purposes of bonding is to allow for redundant links, and failover 
>>correctly if the cable is pulled. If all the members of a bonded device have
>>no carrier present, the bonded device itself needs to report no carrier present
>>to user space so management tools (like routing daemons) can respond.
>>
>>Bonding in 802.3ad mode does not work correctly for this because it incorrectly 
>>chooses a link that is down as a possible aggregator.
>>
>>Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> 	Looks good.  I tested this after putting some printks in the agg
> selection logic, and I don't see any undesirable side effects.
> 
> Signed-off-by: Jay Vosburgh <fubar@...ibm.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html