netdev - Re: [PATCH v2] tcp: fix MSG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.ut38lzvt1e62zd@merlin.emma.line.org>
Date:	Mon, 18 May 2009 10:02:13 +0200
From:	"Matthias Andree" <matthias.andree@....de>
To:	"David Miller" <davem@...emloft.net>, ilpo.jarvinen@...sinki.fi
Cc:	elendil@...net.nl, netdev@...r.kernel.org
Subject: Re: [PATCH v2] tcp: fix MSG_PEEK race check

Am 18.05.2009, 00:31 Uhr, schrieb David Miller <davem@...emloft.net>:

> The issue being discussed there is exactly the case where a thread
> is triggering the copied_seq advance in tcp_check_urg() and using
> MSG_PEEK at the same time.
>
> I'm looking more closely into this patch right now, but I might ask
> you to split the two fixes up if I can't convince myself %100 of the
> URG part.  We've already broken URG enough lately :-)

As long as the non-URG part goes into 2.6.30 (it's a regression fix in my  
perception), I'll be a happy camper - at least that would stop the  
kernel's finger pointing at innocent applications. 8-)

OK, I presume an application is innocent if it doesn't use MSG_OOB flags -  
is that sufficient?

-- 
Matthias Andree
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html