netdev - Re: [PATCH] sch_teql: should not dereference skb after ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090518.193438.158960584.davem@davemloft.net>
Date:	Mon, 18 May 2009 19:34:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org, jussi.kivilinna@...et.fi
Subject: Re: [PATCH] sch_teql: should not dereference skb after
 ndo_start_xmit

From: Eric Dumazet <dada1@...mosbay.com>
Date: Tue, 19 May 2009 03:34:03 +0200

> Looking again at teql_master_xmit(), I wonder if there is another
> problem in it.
> 
>     int subq = skb_get_queue_mapping(skb);
> 
> But as a matter of fact, following code assumes subq is 0
> 
> struct netdev_queue *slave_txq = netdev_get_tx_queue(slave, 0);
> ...
> if (__netif_subqueue_stopped(slave, subq) ||
> ...
> 
> Either we should set subq to 0, or call dev_pick_tx() to better
> take into account multi queue slaves ?
> 
> (As teqlN has one queue, I assume original dev_queue_xmit() will
> set skb queue_mapping to 0 before entering teql_master_xmit(), but
> maybe other paths could call teql_master_xmit() not through dev_queue_xmit() ?
> 
> Oh well, time for sleeping a bit...

I was admittedly very hasty with the multiqueue conversion here.
I'll take a closer look at this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html