netdev - Re: [PATCH 1/2] myri10ge: allow LRO to be enabled via ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090519.142815.254262277.davem@davemloft.net>
Date:	Tue, 19 May 2009 14:28:15 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	brice@...i.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/2] myri10ge: allow LRO to be enabled via ethtool

From: Brice Goglin <brice@...i.com>
Date: Tue, 19 May 2009 22:15:32 +0200

> Allow myri10ge LRO to be enabled/disabled via ethtool
> (and by the stack for packet forwarding).
> 
> Signed-off-by: Brice Goglin <brice@...i.com>

Please also get rid of the module option.  It being there sets
a bad precedent, and others are going to point at your driver
when they try to add such a turd to their's.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html