netdev - Re: [PATCH net-next-2.6] cleanup: remove unused parameter from fill method in fib_rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090519.151857.56095864.davem@davemloft.net>
Date:	Tue, 19 May 2009 15:18:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ramirose@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] cleanup: remove unused parameter from
 fill method in fib_rules_ops.

From: Rami Rosen <ramirose@...il.com>
Date: Tue, 19 May 2009 15:54:26 +0300

> @@ -192,7 +192,7 @@ unsigned dnet_addr_type(__le16 addr)
>  }
>  
>  static int dn_fib_rule_fill(struct fib_rule *rule, struct sk_buff *skb,
> -			    struct nlmsghdr *nlh, struct fib_rule_hdr *frh)
> +			    								  struct fib_rule_hdr *frh)
>  {

Please fix up this crazy multi-line tabbing that happened in
these function arg list transformations.

There's also space-tab sequences in here which should be fixed
up too in fact that's how I noticed the multi-line problem:

+ git apply --check --whitespace=error-all diff
diff:35: space before tab in indent.
			    								  struct fib_rule_hdr *frh)
diff:48: space before tab in indent.
			  									struct fib_rule_hdr *frh)
diff:61: space before tab in indent.
			  									struct fib_rule_hdr *frh)
fatal: 3 lines add whitespace errors.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html