netdev - Re: [PATCH] net: use NLMSG_DEFAULT_SIZE in nlmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090519.152807.141633274.davem@davemloft.net>
Date:	Tue, 19 May 2009 15:28:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	pablo@...filter.org
Cc:	netdev@...r.kernel.org, samuel@...tiz.org,
	johannes@...solutions.net
Subject: Re: [PATCH] net: use NLMSG_DEFAULT_SIZE in nlmsg_new() allocations

From: Pablo Neira Ayuso <pablo@...filter.org>
Date: Tue, 19 May 2009 17:58:20 +0200

> nlmsg_new() adds the size of the netlink header to the value
> that has been passed as parameter. If NLMSG_GOODSIZE is selected,
> we request an allocation of one memory page plus the size of the
> header. Instead, NLMSG_DEFAULT_SIZE should be used since it
> already substracts the size of the Netlink header.
> 
> I have the impression that the similar naming in both constant
> is error prone when using it with nlmsg_new(). This is already
> documented in include/net/netlink.h
> 
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>

Looks good, applied to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html