netdev - PIM-SM namespace changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090518.222429.135907168.davem@davemloft.net>
Date:	Mon, 18 May 2009 22:24:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	thomas.goff@...ing.com
CC:	netdev@...r.kernel.org
Subject: PIM-SM namespace changes


Some bugs to fix before I can apply these Tom.

For one thing, in the IPV4 patch:

 	setup_timer(&ipmr_expire_timer, ipmr_expire_process, 0);
 	err = register_netdevice_notifier(&ip_mr_notifier);
+#ifdef CONFIG_IP_PIMSM_V2
+	if (inet_add_protocol(&pim_protocol, IPPROTO_PIM) < 0) {
+		printk(KERN_ERR "ip_mr_init: can't add PIM protocol\n");
+		err = -EAGAIN;
+	}
+#endif
 	if (err)
 		goto reg_notif_fail;

This adds the protocol even if the notifier registry fails.

It also leaves the notifier registered if the protocol add fails.

Also we need to seriously discuss how now we unconditionally
register the PIM protocols.  Before we had a policy of only
doing so conditionally, and that's a change that needs to
be carefully considered and discussed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html