lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 May 2009 02:48:34 -0700 (PDT) From: David Miller <davem@...emloft.net> To: doug.leith@...m.ie Cc: netdev@...r.kernel.org, shemminger@...tta.com Subject: Re: tcp vegas ssthresh bugfix From: Douglas Leith <doug.leith@...m.ie> Date: Tue, 19 May 2009 10:22:07 +0100 > This patch fixes a minor bug in tcp_vegas.c which affects ssthresh accounting > when vegas congestion control decreases snd_cwnd. > > Signed-off-by: Doug Leith <doug.leith@...m.ie> This patch has several problems: > --- net/ipv4/tcp_vegas.c.orig 2009-04-27 12:55:18.000000000 +0100 > +++ net/ipv4/tcp_vegas.c 2009-05-19 09:25:17.000000000 +0100 The patch should be "-p1" based, one directory higher up. You have it "-p0" based. > + /* Update ssthresh to reflect > + * decreased cwnd */ This is not the correct way to format a comment in the Linux kernel, the correct layout is: /* Update ssthresh to reflect * decreased cwnd. */ Please fix these problems up and resubmit. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists