netdev - Re: [PATCH][be2net] remove napi in the tx path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090518.192309.109435829.davem@davemloft.net>
Date:	Mon, 18 May 2009 19:23:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ajitk@...verengines.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH][be2net] remove napi in the tx path

Actually, I'm not applying this patch at all.

It's garbage.

First of all, your commit message is way too terse.  Why did
you do these things, what are the reasons?  You don't explain
anything.  If it's for performance reasons, you give no
information about that.

Second of all, the change does two things.  One of which you
don't even mention in your subject line, all of this LRO stuff.

Third of all, module parameters ARE NOT THE WAY TO CONTROL LRO!
We have an ethtool command to turn it on and off, via the
ethtool_ops->{set,get}_flags() methods.  So this part of your
change is totally unacceptable.

Your patch submissions, I have to say, are horrible.  Your
patches don't apply cleanly to the net trees, your commit
messages are one-liners at best, and your patches do multiple
unrelated things at the same time.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html