netdev - [PATCH] igb: fix LRO warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20090520061619.13507.27784.stgit@localhost.localdomain>
Date:	Tue, 19 May 2009 23:16:20 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	greg@...ah.com
Cc:	netdev@...r.kernel.org, stable@...nel.org,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	Stephen Hemminger <shemminger@...tta.com>
Subject: [PATCH] igb: fix LRO warning

igb supports LRO, but was not setting any hooks to the ->set_flags
ethtool_ops function.  This would trigger warnings if the user tried
to enable or disable LRO.

Based on the patch provided by Stephen Hemminger <shemminger@...tta.com>

Reported-by: Sergey Kononenko <sergk@...gk.org.ua>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC: Stephen Hemminger <shemminger@...tta.com>
---

 drivers/net/igb/igb_ethtool.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/net/igb/igb_ethtool.c b/drivers/net/igb/igb_ethtool.c
index 3c831f1..44ceb36 100644
--- a/drivers/net/igb/igb_ethtool.c
+++ b/drivers/net/igb/igb_ethtool.c
@@ -2024,6 +2024,10 @@ static struct ethtool_ops igb_ethtool_ops = {
 	.get_ethtool_stats      = igb_get_ethtool_stats,
 	.get_coalesce           = igb_get_coalesce,
 	.set_coalesce           = igb_set_coalesce,
+	.get_flags              = ethtool_op_get_flags,
+#ifdef CONFIG_IGB_LRO
+	.set_flags              = ethtool_op_set_flags,
+#endif
 };
 
 void igb_set_ethtool_ops(struct net_device *netdev)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html