netdev - Re: [PATCH 0/1] NIU: fix spurious interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 21 May 2009 20:40:06 -0400
From:	"Hong H. Pham" <hong.pham@...driver.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, matheos.worku@....com
Subject: Re: [PATCH 0/1] NIU: fix spurious interrupts

David Miller wrote:
> There's a bug in your debugging patch:
> 
> +		ld_im0_reg    = LD_IM0(ldn);
> +		ldg_imgmt_reg = LDG_IMGMT(ldn);
> 
> You're reading the register "address", not the register's "value".
> So all of the debugging output is bogus.
> 
> You need to do nr64(ld_im0_reg) and use that as the value, for
> example.
> 
> Can you rerun the test with this fixed?  Thanks!

I don't know how I missed that.. thanks for pointing it out.  Posted
below is a log with the fix.

What's interesting (baffling?) is that interrupts are being received
with the LD interrupt mask set or cleared.  The mask also changes
in between interrupts.  The mask always changes from 3 to 0, and never
from 0 to 3.

Please let me know if there are other tests you would like me to run
to help track this down.
Regards,
Hong

[113570.320487] niu: eth4: Link is up at 10Gb/sec, full duplex
[113576.834042] NIU: eth4 CPU=5 LDG=41 rx_vec=0x2000: interrupt received while NAPI is in progress
[113576.834066]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113576.834080]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113576.834107] NIU: eth4 CPU=5 LDG=41 rx_vec=0x2000: interrupt received while NAPI is in progress
[113576.834124]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113576.834137]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113576.834164] NIU: eth4 CPU=5 LDG=41 rx_vec=0x2000: interrupt received while NAPI is in progress
[113576.834181]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113576.834195]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113576.834222] NIU: eth4 CPU=5 LDG=41 rx_vec=0x2000: interrupt received while NAPI is in progress
[113576.834239]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113576.834252]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113576.834276] NIU: eth4 CPU=5 LDG=41 rx_vec=0x2000: interrupt received while NAPI is in progress
[113576.834291]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113576.834303]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113576.834326] NIU: eth4 CPU=5 LDG=41 rx_vec=0x2000: interrupt received while NAPI is in progress
[113576.834341]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113576.834353]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113576.834374] NIU: eth4 CPU=5 LDG=41 rx_vec=0x2000: interrupt received while NAPI is in progress
[113576.834389]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113576.834401]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113576.834423] NIU: eth4 CPU=5 LDG=41 rx_vec=0x2000: interrupt received while NAPI is in progress
[113576.834438]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113576.834450]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113578.311747] NIU: eth4 CPU=21 LDG=43 rx_vec=0x8000: interrupt received while NAPI is in progress
[113578.311770]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113578.311782]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113578.311805] NIU: eth4 CPU=21 LDG=43 rx_vec=0x8000: interrupt received while NAPI is in progress
[113578.311821]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113578.311833]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113578.311855] NIU: eth4 CPU=21 LDG=43 rx_vec=0x8000: interrupt received while NAPI is in progress
[113578.311870]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113578.311882]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113578.311904] NIU: eth4 CPU=21 LDG=43 rx_vec=0x8000: interrupt received while NAPI is in progress
[113578.311919]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113578.311931]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113578.311952] NIU: eth4 CPU=21 LDG=43 rx_vec=0x8000: interrupt received while NAPI is in progress
[113578.311968]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113578.311980]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113578.312001] NIU: eth4 CPU=21 LDG=43 rx_vec=0x8000: interrupt received while NAPI is in progress
[113578.312016]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113578.312028]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113578.312050] NIU: eth4 CPU=21 LDG=43 rx_vec=0x8000: interrupt received while NAPI is in progress
[113578.312065]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113578.312077]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113578.312098] NIU: eth4 CPU=21 LDG=43 rx_vec=0x8000: interrupt received while NAPI is in progress
[113578.312114]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113578.312126]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113582.932434] NIU: eth4 CPU=13 LDG=42 rx_vec=0x4000: interrupt received while NAPI is in progress
[113582.932458]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113582.932471]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113582.932499] NIU: eth4 CPU=13 LDG=42 rx_vec=0x4000: interrupt received while NAPI is in progress
[113582.932516]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113582.932529]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113582.932556] NIU: eth4 CPU=13 LDG=42 rx_vec=0x4000: interrupt received while NAPI is in progress
[113582.932571]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113582.932583]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113582.932605] NIU: eth4 CPU=13 LDG=42 rx_vec=0x4000: interrupt received while NAPI is in progress
[113582.932621]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113582.932633]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113582.932655] NIU: eth4 CPU=13 LDG=42 rx_vec=0x4000: interrupt received while NAPI is in progress
[113582.932670]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113582.932682]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113582.932704] NIU: eth4 CPU=13 LDG=42 rx_vec=0x4000: interrupt received while NAPI is in progress
[113582.932719]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113582.932731]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113582.932752] NIU: eth4 CPU=13 LDG=42 rx_vec=0x4000: interrupt received while NAPI is in progress
[113582.932768]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113582.932779]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113582.932801] NIU: eth4 CPU=13 LDG=42 rx_vec=0x4000: interrupt received while NAPI is in progress
[113582.932816]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113582.932828]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113584.656434] NIU: eth4 CPU=58 LDG=40 rx_vec=0x1000: interrupt received while NAPI is in progress
[113584.656459]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113584.656471]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113584.656525] NIU: eth4 CPU=58 LDG=40 rx_vec=0x1000: interrupt received while NAPI is in progress
[113584.656542]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113584.656555]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113584.656581] NIU: eth4 CPU=58 LDG=40 rx_vec=0x1000: interrupt received while NAPI is in progress
[113584.656598]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113584.656612]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113584.656637] NIU: eth4 CPU=58 LDG=40 rx_vec=0x1000: interrupt received while NAPI is in progress
[113584.656653]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113584.656666]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113584.656689] NIU: eth4 CPU=58 LDG=40 rx_vec=0x1000: interrupt received while NAPI is in progress
[113584.656705]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113584.656718]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113584.656740] NIU: eth4 CPU=58 LDG=40 rx_vec=0x1000: interrupt received while NAPI is in progress
[113584.656756]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113584.656768]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113584.656790] NIU: eth4 CPU=58 LDG=40 rx_vec=0x1000: interrupt received while NAPI is in progress
[113584.656806]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113584.656818]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113584.656840] NIU: eth4 CPU=58 LDG=40 rx_vec=0x1000: interrupt received while NAPI is in progress
[113584.656856]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113584.656869]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.659480] NIU: eth4 CPU=50 LDG=39 rx_vec=0x0800: interrupt received while NAPI is in progress
[113591.659502]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113591.659514]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.659537] NIU: eth4 CPU=50 LDG=39 rx_vec=0x0800: interrupt received while NAPI is in progress
[113591.659553]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113591.659565]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.659587] NIU: eth4 CPU=50 LDG=39 rx_vec=0x0800: interrupt received while NAPI is in progress
[113591.659602]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113591.659614]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.659636] NIU: eth4 CPU=50 LDG=39 rx_vec=0x0800: interrupt received while NAPI is in progress
[113591.659651]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113591.659663]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.659685] NIU: eth4 CPU=50 LDG=39 rx_vec=0x0800: interrupt received while NAPI is in progress
[113591.659700]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113591.659712]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.659734] NIU: eth4 CPU=50 LDG=39 rx_vec=0x0800: interrupt received while NAPI is in progress
[113591.659749]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113591.659761]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.659783] NIU: eth4 CPU=50 LDG=39 rx_vec=0x0800: interrupt received while NAPI is in progress
[113591.659798]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113591.659810]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.659832] NIU: eth4 CPU=50 LDG=39 rx_vec=0x0800: interrupt received while NAPI is in progress
[113591.659847]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113591.659859]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.846419] NIU: eth4 CPU=34 LDG=37 rx_vec=0x0200: interrupt received while NAPI is in progress
[113591.846444]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113591.846459]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.846489] NIU: eth4 CPU=34 LDG=37 rx_vec=0x0200: interrupt received while NAPI is in progress
[113591.846508]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113591.846523]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.846551] NIU: eth4 CPU=34 LDG=37 rx_vec=0x0200: interrupt received while NAPI is in progress
[113591.846567]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113591.846579]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.846602] NIU: eth4 CPU=34 LDG=37 rx_vec=0x0200: interrupt received while NAPI is in progress
[113591.846617]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113591.846629]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.846651] NIU: eth4 CPU=34 LDG=37 rx_vec=0x0200: interrupt received while NAPI is in progress
[113591.846666]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113591.846679]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.846700] NIU: eth4 CPU=34 LDG=37 rx_vec=0x0200: interrupt received while NAPI is in progress
[113591.846716]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113591.846727]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.846750] NIU: eth4 CPU=34 LDG=37 rx_vec=0x0200: interrupt received while NAPI is in progress
[113591.846765]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113591.846777]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113591.846798] NIU: eth4 CPU=34 LDG=37 rx_vec=0x0200: interrupt received while NAPI is in progress
[113591.846814]   LD_IM0   =0x0000000000000000 [ldf_mask=0x00]
[113591.846826]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113597.471277] NIU: eth4 CPU=42 LDG=38 rx_vec=0x0400: interrupt received while NAPI is in progress
[113597.471302]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113597.471316]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113597.471346] NIU: eth4 CPU=42 LDG=38 rx_vec=0x0400: interrupt received while NAPI is in progress
[113597.471365]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113597.471379]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113597.471408] NIU: eth4 CPU=42 LDG=38 rx_vec=0x0400: interrupt received while NAPI is in progress
[113597.471426]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113597.471440]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113597.471468] NIU: eth4 CPU=42 LDG=38 rx_vec=0x0400: interrupt received while NAPI is in progress
[113597.471484]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113597.471496]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113597.471518] NIU: eth4 CPU=42 LDG=38 rx_vec=0x0400: interrupt received while NAPI is in progress
[113597.471533]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113597.471545]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113597.471567] NIU: eth4 CPU=42 LDG=38 rx_vec=0x0400: interrupt received while NAPI is in progress
[113597.471582]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113597.471594]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113597.471616] NIU: eth4 CPU=42 LDG=38 rx_vec=0x0400: interrupt received while NAPI is in progress
[113597.471631]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113597.471643]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113597.471665] NIU: eth4 CPU=42 LDG=38 rx_vec=0x0400: interrupt received while NAPI is in progress
[113597.471680]   LD_IM0   =0x0000000000000003 [ldf_mask=0x03]
[113597.471692]   LDG_IMGMT=0x0000000000000000 [arm=0x00 timer=0x00]
[113627.656758] BUG: soft lockup - CPU#5 stuck for 61s! [iperf:3055]


View attachment "niu-instrument-ldg-interrupt.patch" of type "text/x-patch" (2806 bytes)