netdev - Re: [PATCH,RFC] gianfar: fix BUG under load after introduction of skb recycling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <2A79CAF4-334F-4763-82E3-2460377F3078@it-loops.com>
Date:	Sun, 24 May 2009 17:32:05 +0200
From:	Michael Guntsche <mike@...loops.com>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
Cc:	Andy Fleming <afleming@...escale.com>, davem@...emloft.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [PATCH,RFC] gianfar: fix BUG under load after introduction of skb recycling


On May 23, 2009, at 13:51, Lennert Buytenhek wrote:

> Since commit 0fd56bb5be6455d0d42241e65aed057244665e5e ("gianfar:
> Add support for skb recycling"), gianfar puts skbuffs that are in
> the rx ring back onto the recycle list as-is in case there was a
> receive error, but this breaks the following invariant: that all
> skbuffs on the recycle list have skb->data = skb->head + NET_SKB_PAD.
>
>
> Michael, can you re-test with this version of the patch?
> Andy, can you see if this is OK with you?

Hi, I have been running tests with this patch for the last 6 hours and  
had no panics so far.
So it fixes the issues I am seeing as well.

Hope this helps,
Michael
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html