netdev - Re: [net-next-2.6 PATCH][be2net] Code changes to handle dev pvt ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090525.003422.117077559.davem@davemloft.net>
Date:	Mon, 25 May 2009 00:34:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sarveshwarb@...verengines.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next-2.6 PATCH][be2net] Code changes to handle dev pvt
 ioctl

From: Sarveshwar Bandi <sarveshwarb@...verengines.com>
Date: Sun, 24 May 2009 11:01:58 +0530

> Resubmitting patch for net-next tree to handle SIOCDEVPRIVATE ioctl. Also
> have incorporated comments given by Ben Hutchings.
> 
> Signed-off-by: Sarveshwar Bandi <sarveshwarb@...verengines.com>

So what kind of diagnostic commands do userlevel tools need
this for?

If they fall into useful generic categories, I'd rather you add new
ethtool commands for doing them, one for each diagnostic command.
For all I know, we might even have such things already if this is
for self-test, firmware upload/download, or similar.

Device private ioctls are heavily undesirable, because every driver
implements different ones, and thus the experience for users and tool
writers is completely inconsistent.

Until I know more about what this is going to be used for I am
rejecting this patch.

I really don't like any of the changes I've seen submitted recently
for the be2net driver, to be honest with you. :-/

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html