netdev - Re: [PATCH] net: txq_trans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090525.225819.119681427.davem@davemloft.net>
Date:	Mon, 25 May 2009 22:58:19 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: txq_trans_update() helper

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 26 May 2009 07:57:01 +0200

> David Miller a écrit :
>> Closing brace here has strange indentation, which doesn't match
>> the statement of the openning brace.
>> 
>> Please fix this, thanks.
> 
> Oops you are right, this is a leftover.
> 
> [PATCH] net: txq_trans_update() helper
> 
> We would like to get rid of netdev->trans_start = jiffies; that about all net
> drivers have to use in their start_xmit() function, and use txq->trans_start
> instead.
> 
> This can be done generically in core network, as suggested by David.
> 
> Some devices, (particularly loopback) dont need trans_start update, because
> they dont have transmit watchdog. We could add a new device flag, or rely
> on fact that txq->tran_start can be updated is txq->xmit_lock_owner is
> different than -1. Use a helper function to hide our choice.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied, thanks a lot Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html