netdev - Re: [PATCH] netdev: enc28j60: use IRQF_TRIGGER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200905261121.54075.david-b@pacbell.net>
Date:	Tue, 26 May 2009 11:21:53 -0700
From:	David Brownell <david-b@...bell.net>
To:	Mike Frysinger <vapier@...too.org>
Cc:	Baruch Siach <baruch@...s.co.il>,
	Michael Hennerich <michael.hennerich@...log.com>,
	netdev@...r.kernel.org, Bryan Wu <cooloney@...nel.org>
Subject: Re: [PATCH] netdev: enc28j60: use IRQF_TRIGGER_FALLING for IRQ by default

On Tuesday 26 May 2009, Mike Frysinger wrote:
> > > You revert David Brownell's commit here
> > > (c7b7b042068cd12b8b155722d24686f70b88ced1). Added to CC.
> >
> > Right ... the appended patch will *undo* the setting
> > established in the board init code via set_irq_type().
> >
> > Moreover, it completely prevents working on systems which
> > only support "both edges" triggering.
> 
> how can it provide breakage when people are forced to use set_irq_type() ?

It reverses the IRQ setup done by the board code ...
the code which you said they'd have to use to work
around the breakage your patch adds.

If you're really craving some change to the driver,
you should make it take the relevant trigger type
from the platform resource ... instead of hard-wiring
it to a value which is *known* to break systems.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html