netdev - Re: [PATCH] net: txq_trans

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090525.223827.256643479.davem@davemloft.net>
Date:	Mon, 25 May 2009 22:38:27 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: txq_trans_update() helper

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 26 May 2009 07:37:11 +0200

> @@ -302,8 +302,11 @@ static void netpoll_send_skb(struct netpoll *np, struct sk_buff *skb)
>  		for (tries = jiffies_to_usecs(1)/USEC_PER_POLL;
>  		     tries > 0; --tries) {
>  			if (__netif_tx_trylock(txq)) {
> -				if (!netif_tx_queue_stopped(txq))
> +				if (!netif_tx_queue_stopped(txq)) {
>  					status = ops->ndo_start_xmit(skb, dev);
> +					if (status == NETDEV_TX_OK)
> +						txq_trans_update(txq);
> +					}

Closing brace here has strange indentation, which doesn't match
the statement of the openning brace.

Please fix this, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html