netdev - Re: [PATCH] netdev: enc28j60: use IRQF_TRIGGER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200905261743.16036.vapier@gentoo.org>
Date:	Tue, 26 May 2009 17:43:14 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	David Brownell <david-b@...bell.net>
Cc:	Baruch Siach <baruch@...s.co.il>,
	Michael Hennerich <michael.hennerich@...log.com>,
	netdev@...r.kernel.org, Bryan Wu <cooloney@...nel.org>
Subject: Re: [PATCH] netdev: enc28j60: use IRQF_TRIGGER_FALLING for IRQ by default

On Tuesday 26 May 2009 14:21:53 David Brownell wrote:
> On Tuesday 26 May 2009, Mike Frysinger wrote:
> > > > You revert David Brownell's commit here
> > > > (c7b7b042068cd12b8b155722d24686f70b88ced1). Added to CC.
> > >
> > > Right ... the appended patch will *undo* the setting
> > > established in the board init code via set_irq_type().
> > >
> > > Moreover, it completely prevents working on systems which
> > > only support "both edges" triggering.
> >
> > how can it provide breakage when people are forced to use set_irq_type()
> > ?
>
> It reverses the IRQ setup done by the board code ...

how so ?  this code does the irq requesting which means the set_irq_type() 
needs to come after it anyways since the request_irq() will set any flags 
passed to it, right ?

> the code which you said they'd have to use to work
> around the breakage your patch adds.

umm, i'm referring to code the driver and you says should be put in place -- a 
call to set_irq_type() somewhere in the board init code.

> If you're really craving some change to the driver,
> you should make it take the relevant trigger type
> from the platform resource ... instead of hard-wiring
> it to a value which is *known* to break systems.

without any in-tree consumers, it's hard to see how things are supposed to be 
working and how they could possibly break
-mike
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html