netdev - Re: [net-next-2.6 PATCH][be2net] Code changes to handle dev pvt ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090526.145730.86993591.davem@davemloft.net>
Date:	Tue, 26 May 2009 14:57:30 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sarveshwarb@...verengines.com
Cc:	netdev@...r.kernel.org
Subject: Re: [net-next-2.6 PATCH][be2net] Code changes to handle dev pvt
 ioctl

From: Sarveshwar Bandi <sarveshwarb@...verengines.com>
Date: Tue, 26 May 2009 16:18:53 +0530

> 
> The private ioctl is being implemented primarily to meet the following OEM
> requirements.
> 
> 1.  A mechanism to retrieve the last post mortem dump of the firmware and h/w
> state.

Belongs in ethtool.

> 2.  Fine tune port equalization parameters of the physical ports.

Belongs in the driver, definitely not in userspace via random pokes
via this new ioctl.  Maybe it would be OK to do this with a new very
well defined ethtool command.

> 3.  A mechanism to flash the firmware at any point (not just at driver load
> time).

Also belongs in ethtool.

All of this is about the typing of the interface.  What you're adding
with the private ioctl is a big black box that no application
developer can code to and have it work on other cards supporting
similar facilities.

We need consistent interfaces that any driver trying to do this can use,
not a different hack in every driver.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html