netdev - Re: [PATCH 10/14] ipv4: Use 32-bit loads for ID and length in GRO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090527212649.GB22052@gondor.apana.org.au>
Date:	Thu, 28 May 2009 07:26:49 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 10/14] ipv4: Use 32-bit loads for ID and length in GRO

On Wed, May 27, 2009 at 08:00:36PM +0200, Andi Kleen wrote:
>
> On what architecture is that faster?
> 
> At least on x86 they should be the same performance, except that
> the 16bit one is one byte larger, but that shouldn't make a difference.

It shrunk the code by more than a byte, at least with some versions
of gcc on x86-64.

Yes some of these patches might seem a tad trivial, but it does add
up.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html