netdev - Re: [net-next-2.6 PATCH 1/4] ixgbe: fix 82598 SFP initialization after driver load.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090526.204057.193339971.davem@davemloft.net>
Date:	Tue, 26 May 2009 20:40:57 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	netdev@...r.kernel.org, donald.c.skidmore@...el.com,
	peter.p.waskiewicz.jr@...el.com
Subject: Re: [net-next-2.6 PATCH 1/4] ixgbe: fix 82598 SFP initialization
 after driver load.

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Tue, 26 May 2009 17:54:04 -0700

> If we loaded the driver with out a SFP module plugged in it would
> leave it in a state that make it later unable to link when a module
> was plugged in.  This patch corrects that by:
> 
> ixgbe_probe() - moving the check for IXGBE_ERR_SFP_NOT_PRESENT from
> after get_invariants() to after reset_hw() as now reset_hw() is
> where this condition will be indentified.
> 
> ixgbe_reset_hw_82598() - Enable this function to now return
> IXGBE_ERR_SFP_NOT_PRESENT.
> 
> ixgbe_identify_sfp_module_generic() - This where the lack of SFP
> module is detected.  Modifications are added to allow a different
> return value for modules that just haven't been plugged in yet.
> 
> Other functions were updated to allow correct logging.
> 
> Signed-off-by: Don Skidmore <donald.c.skidmore@...el.com>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html