netdev - Re: [PATCH] netdev: enc28j60: use IRQF_TRIGGER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090526.205342.239598826.davem@davemloft.net>
Date:	Tue, 26 May 2009 20:53:42 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	david-b@...bell.net
Cc:	vapier@...too.org, baruch@...s.co.il, michael.hennerich@...log.com,
	netdev@...r.kernel.org, cooloney@...nel.org
Subject: Re: [PATCH] netdev: enc28j60: use IRQF_TRIGGER_FALLING for IRQ by
 default

From: David Brownell <david-b@...bell.net>
Date: Tue, 26 May 2009 18:17:06 -0700

> Wrong.  A set_irq_type() call ensures the IRQ will trigger as
> specified by its parameters (unless it fails).  The current
> request_irq() leaves that "default" setup alone.
> 
> Your patch changes that configuration, making it request
> a trigger mode that (a) the hardware may not support, so
> the request_irq() will fail; else if it succeeds, then
> (b) will clobber whatever mode that was already set up.
> The first certainly breaks things; the second probably
> does so.

I totally agree with David, this patch seems to be wrong on
just about every possible level.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html