netdev - Re: [net-2.6 PATCH V2] mlx4_en: Fix a kernel panic when waking tx queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A1CD8C5.2040507@mellanox.co.il>
Date:	Wed, 27 May 2009 09:08:05 +0300
From:	Yevgeny Petrilin <yevgenyp@...lanox.co.il>
To:	Eric Dumazet <dada1@...mosbay.com>
CC:	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Tziporet Koren <tziporet@...lanox.co.il>
Subject: Re: [net-2.6 PATCH V2] mlx4_en: Fix a kernel panic when waking tx
 queue

Hi Eric,

Eric Dumazet wrote:
>
> Just curious.
>
> Blocking hard IRQ while doing TX completion is quite nasty,
> as freeing one hundred of skb take long.
>
> Could you try something in process context instead ?

I am planning some changes for handling TX completions, but I think it is too
late to
add them to 2.6.30.
In the code that will be submitted to 2.6.31 we will not block irqs.

>
> Is this timer driven tx completion thing really good for performance ?
>
When we are CPU bounded on the transmit side, the driver shown better
performance with
the timer driven completions rather then with interrupts.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html