netdev - Re: [net-next-2.6 PATCH 3/4] ixgbe: remove rx_hdr_split debug counter for non-debug configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1243423017.16597.143.camel@deadeye>
Date:	Wed, 27 May 2009 12:16:57 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	David Miller <davem@...emloft.net>
Cc:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	alexander.h.duyck@...el.com
Subject: Re: [net-next-2.6 PATCH 3/4] ixgbe: remove rx_hdr_split debug
 counter for non-debug configurations

On Tue, 2009-05-26 at 20:38 -0700, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Tue, 26 May 2009 17:54:45 -0700
> 
> > The counter rx_hdr_split was meant to be a debug counter.  As such it
> > should only be enabled when debugging.
> > 
> > Signed-off-by: Alexander Duyck <alexander.h.duyck@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> I disagree with this change.
> 
> Any statistic is useful for diagnosing problems by users, and
> if you hide it behind DEBUG then users never see the facility.
> 
> Either it's unconditionally in the driver or it's unconditionally out.
> I say keep it in :-)

If rx_hdr_split means the same thing at Intel as it does here, it's a
hardware feature Microsoft wants for use in Hyper-V and it won't be
enabled under Linux.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html