netdev - Re: [PATCH 5/6]: nl80211: Eliminate reference to BUS_ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1243503198.16631.14.camel@localhost.localdomain>
Date:	Thu, 28 May 2009 11:33:18 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, kay.sievers@...y.org, greg@...ah.com,
	johannes@...solutions.net
Subject: Re: [PATCH 5/6]: nl80211: Eliminate reference to BUS_ID_SIZE.

Hi Dave,

> >> @@ -57,7 +57,7 @@ static int get_drv_dev_by_info_ifindex(struct nlattr **attrs,
> >>  static struct nla_policy nl80211_policy[NL80211_ATTR_MAX+1] __read_mostly = {
> >>  	[NL80211_ATTR_WIPHY] = { .type = NLA_U32 },
> >>  	[NL80211_ATTR_WIPHY_NAME] = { .type = NLA_NUL_STRING,
> >> -				      .len = BUS_ID_SIZE-1 },
> >> +				      .len = 20-1 },
> >>  	[NL80211_ATTR_WIPHY_TXQ_PARAMS] = { .type = NLA_NESTED },
> >>  	[NL80211_ATTR_WIPHY_FREQ] = { .type = NLA_U32 },
> >>  	[NL80211_ATTR_WIPHY_CHANNEL_TYPE] = { .type = NLA_U32 },
> > 
> > this patch is actually wrong.
> 
> It cannot be right or wrong, it is merely replacing an existing value
> with the constant equivalent.  It is a change which does absolutely
> nothing.

okay, fair enough. It was required when BUS_ID_SIZE was limited and with
the removal of that, the length limitation here should be also removed.

> > You should remove the .len value all together since the phy name has
> > no limit anymore and so shouldn't the netlink API.
> 
> Anyone is free to make that improvement.  But that's now what
> I am trying to accomplish here.

That is again fair enough, but you could just go ahead and remove it ;)

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html