netdev - Re: [patch 2.6.31 08/10] wimax: Add netlink interface to get device state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200905280916.23022.inaky@linux.intel.com>
Date:	Thu, 28 May 2009 09:16:21 -0700
From:	Inaky Perez-Gonzalez <inaky@...ux.intel.com>
To:	wimax@...uxwimax.org
Cc:	Stephen Hemminger <shemminger@...tta.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Paulius Zaleckas <paulius.zaleckas@...tonika.lt>
Subject: Re: [patch 2.6.31 08/10] wimax: Add netlink interface to get device state

On Wednesday 27 May 2009, Stephen Hemminger wrote:
> On Wed, 27 May 2009 18:05:13 -0700
>
> Inaky Perez-Gonzalez <inaky@...ux.intel.com> wrote:
> > From: Paulius Zaleckas <paulius.zaleckas@...tonika.lt>
> >
> > wimax connection manager / daemon has to know what is current
> > state of the device. Previously it was only possible to get
> > notification whet state has changed.
> >
> > ...
> > ...
> > > > diff --git a/include/linux/wimax.h b/include/linux/wimax.h 
> > index c89de7f..c750f42 100644
> > --- a/include/linux/wimax.h
> > +++ b/include/linux/wimax.h
> > @@ -77,6 +77,7 @@ enum {
> >  	WIMAX_GNL_OP_MSG_TO_USER,	/* Kernel to user message */
> >  	WIMAX_GNL_OP_RFKILL,	/* Run wimax_rfkill() */
> >  	WIMAX_GNL_OP_RESET,	/* Run wimax_rfkill() */
> > +	WIMAX_GNL_OP_STATE_GET,		/* Request for current state */
> >  	WIMAX_GNL_RE_STATE_CHANGE,	/* Report: status change */
> >  };
>
> Won't adding new element in middle of list break existing ABI?

Actually that's an extremely good point that I missed completely. 
Thanks for catching it.

David, I'll submit an extra commit for correcting that point.


-- 
Inaky
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html