netdev - RE: [net-next-2.6 PATCH 3/4] ixgbe: remove rx_hdr_split debug counter for non-debug configurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80769D7B14936844A23C0C43D9FBCF0F44CF8060@orsmsx501.amr.corp.intel.com>
Date:	Thu, 28 May 2009 17:01:17 -0700
From:	"Duyck, Alexander H" <alexander.h.duyck@...el.com>
To:	David Miller <davem@...emloft.net>,
	"bhutchings@...arflare.com" <bhutchings@...arflare.com>
CC:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [net-next-2.6 PATCH 3/4] ixgbe: remove rx_hdr_split debug
 counter for non-debug configurations

David Miller wrote:
> From: Ben Hutchings <bhutchings@...arflare.com>
> Date: Wed, 27 May 2009 12:16:57 +0100
> 
>> If rx_hdr_split means the same thing at Intel as it does here, it's a
>> hardware feature Microsoft wants for use in Hyper-V and it won't be
>> enabled under Linux.
> 
> Nobody explains anything, so it could or it could not be, who knows.
> :-)

The feature mentioned here is header-data split.  When it is enabled the igb driver puts the header into skb data, and the remainder into the page frags list.  It is used when we enable jumbo frames on the igb driver.  The counter I had removed in the patch was keeping track of the split header bit which is 1 when the header size reflected in the descriptor is correct.

The counter didn't really have much use other than in our early validation work to make certain the silicon was working as documented.  If it stays it isn't too big a concern I just figured it might be nice to remove it since igb is a multiqueue driver and having a global counter can cause some cache thrash on multicore systems.

Thanks,

Alex--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html