netdev - Re: [PATCH iproute2] Re: HTB accuracy for high speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090529194643.GA2753@ami.dom.local>
Date:	Fri, 29 May 2009 21:46:43 +0200
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Antonio Almeida <vexwek@...il.com>
Cc:	Stephen Hemminger <shemminger@...tta.com>, netdev@...r.kernel.org,
	kaber@...sh.net, davem@...emloft.net, devik@....cz,
	Eric Dumazet <dada1@...mosbay.com>,
	Vladimir Ivashchenko <hazard@...ncoudi.com>
Subject: Re: [PATCH iproute2] Re: HTB accuracy for high speed

On Fri, May 29, 2009 at 06:02:39PM +0100, Antonio Almeida wrote:
> On Thu, May 28, 2009 at 10:12 PM, Jarek Poplawski wrote:
> > Yes, but according to my assessment there should be "only" 50Mbit
> > difference for this rate/packet size. Anyway, could you try a testing
> > patch below, which should add some granularity to this rate table?
> >
> > Thanks,
> > Jarek P.
> > ---
> >
> >  include/net/pkt_sched.h |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/net/pkt_sched.h b/include/net/pkt_sched.h
> > index e37fe31..f0faf03 100644
> > --- a/include/net/pkt_sched.h
> > +++ b/include/net/pkt_sched.h
> > @@ -42,8 +42,8 @@ typedef u64   psched_time_t;
> >  typedef long   psched_tdiff_t;
> >
> >  /* Avoid doing 64 bit divide by 1000 */
> > -#define PSCHED_US2NS(x)                        ((s64)(x) << 10)
> > -#define PSCHED_NS2US(x)                        ((x) >> 10)
> > +#define PSCHED_US2NS(x)                        ((s64)(x) << 6)
> > +#define PSCHED_NS2US(x)                        ((x) >> 6)
> >
> >  #define PSCHED_TICKS_PER_SEC           PSCHED_NS2US(NSEC_PER_SEC)
> >  #define PSCHED_PASTPERFECT             0
> 
> It's better! This patch gives more accuracy to HTB. Here some values:
> Note that these are boundary values, so, e.g., any HTB configuration
> between 377000Kbit and 400000Kbit would fall in the same step - close
> to 397977Kbit.

Good news! So it seems there are no other reasons of this inaccuracy
than too coarse granularity, but I have to check this yet. Alas there
is needed something more than this patch, because it probably breaks
other things like hfsc.

Thanks,
Jarek P.

> This test was made over the same conditions: generating 950Mbit/s of
> unidirectional tcp traffic of 800 bytes packets long.
> 
> leaf class ceil	leaf class sent rate (tc -s values)
> 376000Kbit	375379Kbit
> --
> 377000Kbit	397977Kbit
> 400000Kbit	397973Kbit
> --
> 401000Kbit	425199Kbit
> 426000Kbit	425199Kbit
> --
> 427000Kbit	456389Kbit
> 457000Kbit	456409Kbit
> --
> 458000Kbit	490111Kbit
> 492000Kbit	490138Kbit
> --
> 493000Kbit	531957Kbit
> 533000Kbit	532078Kbit
> --
> 534000Kbit	581835Kbit
> 581000Kbit	581820Kbit
> --
> 582000Kbit	637809Kbit
> 640000Kbit	637709Kbit
> --
> 641000Kbit	710526Kbit
> 711000Kbit	710553Kbit
> --
> 712000Kbit	795921Kbit
> 800000Kbit	795901Kbit
> --
> 801000Kbit	912706Kbit
> 914000Kbit	912782Kbit
> --
> 915000Kbit	--
> 
> 
> Here more values for a HTB ceil configuration of 555Mbit/s changing packet size:
> 
> 800 bytes:
> class htb 1:108 parent 1:10 leaf 108: prio 7 quantum 1514 rate
> 555000Kbit ceil 555000Kbit burst 70901b/8 mpu 0b overhead 0b cburst
> 70901b/8 mpu 0b overhead 0b level 0
>  Sent 18731000768 bytes 23531408 pkt (dropped 15715520, overlimits 0 requeues 0)
>  rate 581832Kbit 91368pps backlog 0b 110p requeues 0
>  lended: 23531298 borrowed: 0 giants: 0
>  tokens: -16091 ctokens: -16091
> 
> 
> 850 bytes:
> class htb 1:108 parent 1:10 leaf 108: prio 7 quantum 1514 rate
> 555000Kbit ceil 555000Kbit burst 70901b/8 mpu 0b overhead 0b cburst
> 70901b/8 mpu 0b overhead 0b level 0
>  Sent 30556163150 bytes 37645600 pkt (dropped 25746491, overlimits 0 requeues 0)
>  rate 565509Kbit 83556pps backlog 0b 15p requeues 0
>  lended: 37645585 borrowed: 0 giants: 0
>  tokens: -16010 ctokens: -16010
> 
> 
> 950 bytes	
> class htb 1:108 parent 1:10 leaf 108: prio 7 quantum 1514 rate
> 555000Kbit ceil 555000Kbit burst 70901b/8 mpu 0b overhead 0b cburst
> 70901b/8 mpu 0b overhead 0b level 0
>  Sent 51363059854 bytes 60954074 pkt (dropped 40474346, overlimits 0 requeues 0)
>  rate 598925Kbit 83555pps backlog 0b 112p requeues 0
>  lended: 60953962 borrowed: 0 giants: 0
>  tokens: 12446 ctokens: 12446
> 
> I'm using
> # tc -V
> tc utility, iproute2-ss090115
> 
> and keeping tso and gso off:
> # ethtool -k eth0
> Offload parameters for eth0:
> rx-checksumming: on
> tx-checksumming: on
> scatter-gather: on
> tcp segmentation offload: off
> udp fragmentation offload: off
> generic segmentation offload: off
> 
> # ethtool -k eth1
> Offload parameters for eth1:
> rx-checksumming: on
> tx-checksumming: on
> scatter-gather: on
> tcp segmentation offload: off
> udp fragmentation offload: off
> generic segmentation offload: off
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html