netdev - Re: [PATCH net-next] bonding: allow bond in mode balance-alb to work properly in bridge -try4.3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090529.015232.113333227.davem@davemloft.net>
Date:	Fri, 29 May 2009 01:52:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	jpirko@...hat.com, netdev@...r.kernel.org, jgarzik@...ox.com,
	shemminger@...ux-foundation.org, bridge@...ts.linux-foundation.org,
	fubar@...ibm.com, bonding-devel@...ts.sourceforge.net,
	kaber@...sh.net, mschmidt@...hat.com, andy@...yhouse.net,
	oleg@...hat.com
Subject: Re: [PATCH net-next] bonding: allow bond in mode balance-alb to
 work properly in bridge -try4.3

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 28 May 2009 13:41:59 +0200

> Jiri Pirko a écrit :
>> [PATCH net-next] bonding: allow bond in mode balance-alb to work properly in bridge -try4.3
>> 
>> (updated)
>> changes v4.2 -> v4.3
>> - memcpy the address always, not just in case it differs from master->dev_addr
>> - compare_ether_addr_64bits() is not used so there is no direct need to make new
>>   header file (I think it would be good to have bond stuff in separate file
>>   anyway).
> 
> Yes, this could be done in a future cleanup patch.
> I find this (short) version easier to review for a new feature.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html