netdev - Re: [resend] Passive OS fingerprint xtables match.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.00.0905291144460.9095@fbirervta.pbzchgretzou.qr>
Date:	Fri, 29 May 2009 11:49:51 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Evgeniy Polyakov <zbr@...emap.net>
cc:	Patrick McHardy <kaber@...sh.net>, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Netfilter Development Mailinglist 
	<netfilter-devel@...r.kernel.org>
Subject: Re: [resend] Passive OS fingerprint xtables match.


On Friday 2009-05-29 10:59, Evgeniy Polyakov wrote:
>> >+/* Defines for IANA option kinds */
>> >+
>> >+enum iana_options {
>> >+	OSFOPT_EOL = 0,		/* End of options */
>> >+	OSFOPT_NOP, 		/* NOP */
>> >+	OSFOPT_MSS, 		/* Maximum segment size */
>> >+	OSFOPT_WSO, 		/* Window scale option */
>> >+	OSFOPT_SACKP,		/* SACK permitted */
>> >+	OSFOPT_SACK,		/* SACK */
>> >+	OSFOPT_ECHO,
>> >+	OSFOPT_ECHOREPLY,
>> >+	OSFOPT_TS,		/* Timestamp option */
>> >+	OSFOPT_POCP,		/* Partial Order Connection Permitted */
>> >+	OSFOPT_POSP,		/* Partial Order Service Profile */
>> >+
>> >+	/* Others are not used in the current OSF */
>> >+	OSFOPT_EMPTY = 255,
>> >+};
>> 
>> Why do we need to duplicate these?
>
>Why duplicate? It is the only place of the constants describing used
>option numbers. include/net/tcp.h does not have 'partial order' options
>in particular.

Then you do one of these:

1. add TCPOPT_POCP/POSP to tcp.h or
2. define it locally:
#include <net/tcp.h>
enum {
	TCPOPT_POCP = 9,
	TCPOPT_POSP = 10,
};

>> >+config NETFILTER_XT_MATCH_OSF
>> >+	tristate '"osf" Passive OS fingerprint match'
>> >+	depends on NETFILTER_ADVANCED
>> 
>> && NFNETLINK
>
>Will add.

Does it really need to depend on nfnetlink? Even if I just want to
have it dumped to syslog?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html