netdev - Re: [PATCH 4/10]: rtl8187: Remove pointless check in rtl8187_rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090529101834.GC3506@tuxdriver.com>
Date:	Fri, 29 May 2009 12:18:35 +0200
From:	"John W. Linville" <linville@...driver.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH 4/10]: rtl8187: Remove pointless check in
	rtl8187_rx_cb().

On Fri, May 29, 2009 at 01:40:11AM -0700, David Miller wrote:
> 
> First of all, it exposes the SKB list implementation.
> 
> Second of all it's not needed.  If we get called here, we
> successfully enqueued the URB with the linked SKB and
> such a completion only gets called one time on such an
> SKB.
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>

ACK

-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html