netdev - RE: [Uclinux-dist-devel] [PATCH 1/5] netdev: bfin_mac: Blackfin EMAC interrupt may not be shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 May 2009 12:12:49 +0100
From:	"Hennerich, Michael" <Michael.Hennerich@...log.com>
To:	"David Miller" <davem@...emloft.net>, <vapier.adi@...il.com>
CC:	<netdev@...r.kernel.org>, <uclinux-dist-devel@...ckfin.uclinux.org>
Subject: RE: [Uclinux-dist-devel] [PATCH 1/5] netdev: bfin_mac: Blackfin EMAC interrupt may not be shared



>From: David Miller [mailto:davem@...emloft.net]
>From: Mike Frysinger <vapier.adi@...il.com>
>Date: Fri, 29 May 2009 06:49:42 -0400
>
>> the hardware has a dedicated internal IRQ line for the Blackfin MAC.
>> it makes no sense to mark it as shared.  there is nothing it could
>> possibly be shared with.
>
>Then why bother messing with the flag away at all?  It doesn't fix
>anything.

Well - it fixes a bug seen with CONFIG_DEBUG_SHIRQ.
CONFIG_DEBUG_SHIRQ generates spurious fake interrupts and 
checks if the handler can cope with them. 
This is basically a good thing - however only for real shared
interrupts.

Our handler isn't prepared to handle such fake interrupts.
So two options:
1) Set the proper IRQF flags.
2) Fix the ISR to handle spurious interrupts.

This patch chose option 1) 

-Michael 
 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html