netdev - Re: [BUG] net_cls: Panic occured when net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 May 2009 09:15:16 -0400
From:	jamal <hadi@...erus.ca>
To:	Jarek Poplawski <jarkao2@...il.com>
Cc:	Minoru Usui <usui@....nes.nec.co.jp>, netdev@...r.kernel.org,
	containers@...ts.linux-foundation.org
Subject: Re: [BUG] net_cls: Panic occured when net_cls subsystem use

Thanks for the CC Jarek.

On Fri, 2009-05-29 at 10:22 +0000, Jarek Poplawski wrote:

> > > I didn't verify this too much, so I might be wrong, but it looks like
> > > cls_cgroup_classify() does things a bit different than others (doesn't
> > > check the 'head' etc. for NULL), so maybe you should consider fixing
> > > it instead? (Btw., the tc classifier maintainer added to Cc).
> > 
> > OOPS! Others mostly don't check this either, so my suggestion was wrong.
> 
> Hmm... Or maybe I wasn't so wrong; it seems classifiers which
> don't assign the head during init do this check for NULL later.

It is good practise to initialize things in init() and use attributes
in change() to set them. 
I will read the thread and check out the code path then respond
more intelligently.

cheers,
jamal

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html