netdev - Re: [PATCH net-next] net: convert unicast addr list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090529.221528.251215500.davem@davemloft.net>
Date:	Fri, 29 May 2009 22:15:28 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jpirko@...hat.com
Cc:	netdev@...r.kernel.org, jeffrey.t.kirsher@...el.com,
	jesse.brandeburg@...el.com, bruce.w.allan@...el.com,
	peter.p.waskiewicz.jr@...el.com, john.ronciak@...el.com
Subject: Re: [PATCH net-next] net: convert unicast addr list

From: Jiri Pirko <jpirko@...hat.com>
Date: Sat, 23 May 2009 11:22:17 +0200

> [PATCH net-next] net: convert unicast addr list
> 
> This patch converts unicast address list to standard list_head using previously
> introduced struct netdev_hw_addr. It also relaxes the locking. Original spinlock
> (still used for multicast addresses) is not needed and is no longer used for a
> protection of this list. All reading and writing takes place under rtnl (with no
> changes).
> 
> I also removed a possibility to specify the length of the address while adding
> or deleting unicast address. It's always dev->addr_len.
> 
> The convertion touched especially e1000 and ixgbe codes when the change is not
> so trivial.
> 
> Signed-off-by: Jiri Pirko <jpirko@...hat.com>

Even though this touches some drivers non-trivially I like the
change a lot and driver folks have had multiple days to look
this over and say "hold off" if there were any major objections
and they didn't.

So applied to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html